-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New concepts allowed even if name alrady exists in imported ontologies #504
New concepts allowed even if name alrady exists in imported ontologies #504
Conversation
Codecov Report
@@ Coverage Diff @@
## master #504 +/- ##
=======================================
Coverage 63.06% 63.06%
=======================================
Files 16 16
Lines 3081 3081
=======================================
Hits 1943 1943
Misses 1138 1138
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There seems to be an issue with It seems that it is caused by self._label_annotations = [] This change shows another issue on ontology.py line 377. If try:
entity = self.world.search(**{next(annotations): label})
except StopIteration:
entity = []
|
…s with a given base_iri
Description:
Previously, names with prefLababels already present in the ontology including imported ontologies were
not allowed to be added.
This is now changed so that it is allowed to use another preflabel, provided that the base_iri of the new
ontology is not equal to that of the imported ontology with the already existing prefLabel.
Test rewritten accordinngly.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: